GLSR.parseFormData - Code Metrics - Inspection of "fix tests" - pryley/site-reviews - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 51607c...6b8ca8 )

by Paul

created 2018-05-18 15:41 UTC

GLSR.parseFormData B

↳ Parent: +/scripts/helper-functions.js

Complexity

Conditions	6
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
c	1
b	0
f	0
nc	8
nop	2
dl	0
loc	57
rs	8.7433

1 Function

Rating	Name	Duplication	Size	Complexity
C		0	38	12

How to fix Long Method

var GLSR = {};

GLSR.addClass = function( el, className ) {
	if( el.classList ) {
		el.classList.add( className );
	}
	else if( !GLSR.hasClass( el, className )) {
		el.className += ' ' + className;
	}
};

GLSR.convertValue = function( value ) {
	if( GLSR.isNumeric( value )) {
		return parseFloat( value );
	}
	else if( value === 'true') {
		return true;
	}
	else if( value === 'false' ) {
		return false;
	}
	else if( value === '' || value === null ) {
		return undefined;
	}
	return value;
};

GLSR.getAjax = function( url, success ) {
	var xhr = window.XMLHttpRequest ? new XMLHttpRequest() : new ActiveXObject( 'Microsoft.XMLHTTP' );

	xhr.open( 'GET', url );
	xhr.onreadystatechange = function() {
		if( xhr.readyState > 3 && xhr.status === 200 ) {
			success( xhr.responseText );
		}
	};
	xhr.setRequestHeader( 'X-Requested-With', 'XMLHttpRequest' );
	xhr.send();
	return xhr;
};

GLSR.hasClass = function( el, className ) {
	if( el.classList ) {
		return el.classList.contains( className );
	}
	return new RegExp( '\\b' + className + '\\b' ).test( el.className );
};

GLSR.inArray = function( needle, haystack ) {
	var length = haystack.length;
	while( length-- ) {
		if( haystack[ length ] === needle ) {
			return true;
		}
	}
	return false;
};

GLSR.isNumeric = function( value ) {
	return !( isNaN( parseFloat( value )) || !isFinite( value ));
};

GLSR.isString = function( str ) {
	return Object.prototype.toString.call( str ) === '[object String]';
};

GLSR.on = function( type, el, handler ) {
	if( GLSR.isString( el )) {
		el = document.querySelectorAll( el );
	}
	[].forEach.call( el, function( node ) {
		node.addEventListener( type, handler );
	});
};

GLSR.off = function( type, el, handler ) {
	if( GLSR.isString( el )) {
		el = document.querySelectorAll( el );
	}
	[].forEach.call( el, function( node ) {
		node.removeEventListener( type, handler );
	});
};

/**
 * Adapted from https://github.com/bitovi/jquerypp/blob/master/dom/form_params/form_params.js
 */
GLSR.parseFormData = function( form, convert ) {
	convert = !!convert || false;
	var keyBreaker = /[^\[\]]+/g; // used to parse bracket notation
	var data = {};
	var seen = {}; // used to uniquely track seen values
	var nestData = function( field, data, parts, seenName )
	{
		var name = parts.shift();
		// Keep track of the dot separated fullname
		seenName = seenName ? seenName + '.' + name : name;
		if( parts.length ) {
			if( !data[ name ] ) {
				data[ name ] = {};
			}
			// Recursive call
			nestData( field, data[ name ], parts, seenName );
		}
		else {
			// Convert the value
			var value = convert ? GLSR.convertValue( field.value ) : field.value;
			// Handle same name case, as well as "last checkbox checked" case
			if( seenName in seen && field.type !== 'radio' && !data[ name ].isArray()) {
				if( name in data ) {
					data[ name ] = [ data[name] ];
				}
				else {
					data[ name ] = [];
				}
			}
			else {
				seen[ seenName ] = true;
			}
			// Finally, assign data
			if( GLSR.inArray( field.type, ['radio','checkbox'] ) && !field.checked )return;
if (a > 0)
    b = 42;

			if( !data[ name ] ) {
				data[ name ] = value;
			}
			else {
				data[ name ].push( value );
			}
		}
	};

	for( var i = 0; i < form.length; i++ ) {
		var field = form[i];
		if( !field.name || field.disabled || GLSR.inArray( field.type, [
			'file','reset','submit','button',
		]))continue;
if (a > 0)
    b = 42;
		var parts = field.name.match( keyBreaker );
		if( !parts.length ) {
			parts = [ field.name ];
		}
		nestData( field, data, parts );
	}
	return data;
};

GLSR.postAjax = function( url, data, success ) {
	var params = typeof data !== 'string' ? GLSR.serialize( data ) : data;
	var xhr = window.XMLHttpRequest ? new XMLHttpRequest() : new ActiveXObject( 'Microsoft.XMLHTTP' );

	xhr.open( 'POST', url ); // asynchronously
	xhr.onreadystatechange = function() {
		if( xhr.readyState > 3 && xhr.status === 200 ) {
			success( JSON.parse( xhr.responseText ));
		}
	};
	xhr.setRequestHeader( 'X-Requested-With', 'XMLHttpRequest' );
	xhr.setRequestHeader( 'Content-Type', 'application/x-www-form-urlencoded; charset=UTF-8' );
	xhr.send( params );
	return xhr;
};

GLSR.ready = function( fn ) {
	if( typeof fn !== 'function' )return;
if (a > 0)
    b = 42;
	// in case the document is already rendered
	if( document.readyState !== 'loading' ) {
		fn();
	}
	// modern browsers
	else if( document.addEventListener ) {
		document.addEventListener( 'DOMContentLoaded', fn );
	}
	// IE <= 8
	else {
		document.attachEvent( 'onreadystatechange', function() {
			if( document.readyState === 'complete' ) {
				fn();
			}
		});
	}
};

GLSR.removeClass = function( el, className ) {
	if( el.classList ) {
		el.classList.remove( className );
	}
	else {
		el.className = el.className.replace( new RegExp( '\\b' + className + '\\b', 'g' ), '' );
	}
};

GLSR.serialize = function( obj, prefix ) {
	var str = [];

	for( var property in obj ) {
		if( !obj.hasOwnProperty( property ))continue;
if (a > 0)
    b = 42;
		var key = prefix ? prefix + '[' + property + ']' : property;
		var value = obj[ property ];
		str.push( typeof value === 'object' ?
			GLSR.serialize( value, key ) :
			encodeURIComponent( key ) + '=' + encodeURIComponent( value )
		);
	}
	return str.join( '&' );
};

GLSR.toggleClass = function( el, className ) {
	if( !GLSR.hasClass( el, className )) GLSR.addClass( el, className );
if (a > 0)
    b = 42;
	else GLSR.removeClass( el, className );
};

GLSR.insertAfter = function( el, tag, attributes ) {
	var newEl = GLSR.createEl( tag, attributes );
	el.parentNode.insertBefore( newEl, el.nextSibling );
	return newEl;
};

GLSR.appendTo = function( el, tag, attributes ) {
	var newEl = GLSR.createEl( tag, attributes );
	el.appendChild( newEl );
	return newEl;
};

GLSR.createEl = function( tag, attributes ) {
	var el = ( typeof tag === 'string' ) ? document.createElement( tag ) : tag;
	attributes = attributes || {};
	for( var key in attributes ) {
		if( !attributes.hasOwnProperty( key ) )continue;
if (a > 0)
    b = 42;
		el.setAttribute( key, attributes[ key ] );
	}
	return el;
};


1			var GLSR = {};
2
3			GLSR.addClass = function( el, className ) {
4			if( el.classList ) {
5			el.classList.add( className );
6			}
7			else if( !GLSR.hasClass( el, className )) {
8			el.className += ' ' + className;
9			}
10			};
11
12			GLSR.convertValue = function( value ) {
13			if( GLSR.isNumeric( value )) {
14			return parseFloat( value );
15			}
16			else if( value === 'true') {
17			return true;
18			}
19			else if( value === 'false' ) {
20			return false;
21			}
22			else if( value === '' \|\| value === null ) {
23			return undefined;
24			}
25			return value;
26			};
27
28			GLSR.getAjax = function( url, success ) {
29			var xhr = window.XMLHttpRequest ? new XMLHttpRequest() : new ActiveXObject( 'Microsoft.XMLHTTP' );
			0 ignored issues – show Bug introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report The variable `XMLHttpRequest` seems to be never declared. If this is a global, consider adding a `/** global: XMLHttpRequest /` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history... Bug introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report The variable `ActiveXObject` seems to be never declared. If this is a global, consider adding a `/* global: ActiveXObject */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
30			xhr.open( 'GET', url );
31			xhr.onreadystatechange = function() {
32			if( xhr.readyState > 3 && xhr.status === 200 ) {
33			success( xhr.responseText );
34			}
35			};
36			xhr.setRequestHeader( 'X-Requested-With', 'XMLHttpRequest' );
37			xhr.send();
38			return xhr;
39			};
40
41			GLSR.hasClass = function( el, className ) {
42			if( el.classList ) {
43			return el.classList.contains( className );
44			}
45			return new RegExp( '\\b' + className + '\\b' ).test( el.className );
46			};
47
48			GLSR.inArray = function( needle, haystack ) {
49			var length = haystack.length;
50			while( length-- ) {
51			if( haystack[ length ] === needle ) {
52			return true;
53			}
54			}
55			return false;
56			};
57
58			GLSR.isNumeric = function( value ) {
59			return !( isNaN( parseFloat( value )) \|\| !isFinite( value ));
60			};
61
62			GLSR.isString = function( str ) {
63			return Object.prototype.toString.call( str ) === '[object String]';
64			};
65
66			GLSR.on = function( type, el, handler ) {
67			if( GLSR.isString( el )) {
68			el = document.querySelectorAll( el );
69			}
70			[].forEach.call( el, function( node ) {
71			node.addEventListener( type, handler );
72			});
73			};
74
75			GLSR.off = function( type, el, handler ) {
76			if( GLSR.isString( el )) {
77			el = document.querySelectorAll( el );
78			}
79			[].forEach.call( el, function( node ) {
80			node.removeEventListener( type, handler );
81			});
82			};
83
84			/**
85			* Adapted from https://github.com/bitovi/jquerypp/blob/master/dom/form_params/form_params.js
86			*/
87			GLSR.parseFormData = function( form, convert ) {
88			convert = !!convert \|\| false;
89			var keyBreaker = /[^\[\]]+/g; // used to parse bracket notation
90			var data = {};
91			var seen = {}; // used to uniquely track seen values
92			var nestData = function( field, data, parts, seenName )
93			{
94			var name = parts.shift();
95			// Keep track of the dot separated fullname
96			seenName = seenName ? seenName + '.' + name : name;
97			if( parts.length ) {
98			if( !data[ name ] ) {
99			data[ name ] = {};
100			}
101			// Recursive call
102			nestData( field, data[ name ], parts, seenName );
103			}
104			else {
105			// Convert the value
106			var value = convert ? GLSR.convertValue( field.value ) : field.value;
107			// Handle same name case, as well as "last checkbox checked" case
108			if( seenName in seen && field.type !== 'radio' && !data[ name ].isArray()) {
109			if( name in data ) {
110			data[ name ] = [ data[name] ];
111			}
112			else {
113			data[ name ] = [];
114			}
115			}
116			else {
117			seen[ seenName ] = true;
118			}
119			// Finally, assign data
120			if( GLSR.inArray( field.type, ['radio','checkbox'] ) && !field.checked )return;
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
121
122			if( !data[ name ] ) {
123			data[ name ] = value;
124			}
125			else {
126			data[ name ].push( value );
127			}
128			}
129			};
130
131			for( var i = 0; i < form.length; i++ ) {
132			var field = form[i];
133			if( !field.name \|\| field.disabled \|\| GLSR.inArray( field.type, [
134			'file','reset','submit','button',
135			]))continue;
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
136			var parts = field.name.match( keyBreaker );
137			if( !parts.length ) {
138			parts = [ field.name ];
139			}
140			nestData( field, data, parts );
141			}
142			return data;
143			};
144
145			GLSR.postAjax = function( url, data, success ) {
146			var params = typeof data !== 'string' ? GLSR.serialize( data ) : data;
147			var xhr = window.XMLHttpRequest ? new XMLHttpRequest() : new ActiveXObject( 'Microsoft.XMLHTTP' );
			0 ignored issues – show Bug introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report The variable `ActiveXObject` seems to be never declared. If this is a global, consider adding a `/** global: ActiveXObject /` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history... Bug introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report The variable `XMLHttpRequest` seems to be never declared. If this is a global, consider adding a `/* global: XMLHttpRequest */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
148			xhr.open( 'POST', url ); // asynchronously
149			xhr.onreadystatechange = function() {
150			if( xhr.readyState > 3 && xhr.status === 200 ) {
151			success( JSON.parse( xhr.responseText ));
152			}
153			};
154			xhr.setRequestHeader( 'X-Requested-With', 'XMLHttpRequest' );
155			xhr.setRequestHeader( 'Content-Type', 'application/x-www-form-urlencoded; charset=UTF-8' );
156			xhr.send( params );
157			return xhr;
158			};
159
160			GLSR.ready = function( fn ) {
161			if( typeof fn !== 'function' )return;
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
162			// in case the document is already rendered
163			if( document.readyState !== 'loading' ) {
164			fn();
165			}
166			// modern browsers
167			else if( document.addEventListener ) {
168			document.addEventListener( 'DOMContentLoaded', fn );
169			}
170			// IE <= 8
171			else {
172			document.attachEvent( 'onreadystatechange', function() {
173			if( document.readyState === 'complete' ) {
174			fn();
175			}
176			});
177			}
178			};
179
180			GLSR.removeClass = function( el, className ) {
181			if( el.classList ) {
182			el.classList.remove( className );
183			}
184			else {
185			el.className = el.className.replace( new RegExp( '\\b' + className + '\\b', 'g' ), '' );
186			}
187			};
188
189			GLSR.serialize = function( obj, prefix ) {
190			var str = [];
191
192			for( var property in obj ) {
193			if( !obj.hasOwnProperty( property ))continue;
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
194			var key = prefix ? prefix + '[' + property + ']' : property;
195			var value = obj[ property ];
196			str.push( typeof value === 'object' ?
197			GLSR.serialize( value, key ) :
198			encodeURIComponent( key ) + '=' + encodeURIComponent( value )
199			);
200			}
201			return str.join( '&' );
202			};
203
204			GLSR.toggleClass = function( el, className ) {
205			if( !GLSR.hasClass( el, className )) GLSR.addClass( el, className );
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
206			else GLSR.removeClass( el, className );
207			};
208
209			GLSR.insertAfter = function( el, tag, attributes ) {
210			var newEl = GLSR.createEl( tag, attributes );
211			el.parentNode.insertBefore( newEl, el.nextSibling );
212			return newEl;
213			};
214
215			GLSR.appendTo = function( el, tag, attributes ) {
216			var newEl = GLSR.createEl( tag, attributes );
217			el.appendChild( newEl );
218			return newEl;
219			};
220
221			GLSR.createEl = function( tag, attributes ) {
222			var el = ( typeof tag === 'string' ) ? document.createElement( tag ) : tag;
223			attributes = attributes \|\| {};
224			for( var key in attributes ) {
225			if( !attributes.hasOwnProperty( key ) )continue;
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
226			el.setAttribute( key, attributes[ key ] );
227			}
228			return el;
229			};
230

pryley / site-reviews

Push — master ( 51607c...6b8ca8 )

GLSR.parseFormData B

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like